[
https://issues.apache.org/jira/browse/ARTEMIS-1706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379249#comment-16379249
]
ASF GitHub Bot commented on ARTEMIS-1706:
-----------------------------------------
Github user tabish121 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1903#discussion_r171060932
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyAcceptor.java
---
@@ -468,8 +473,12 @@ public synchronized SslHandler
getSslHandler(ByteBufAllocator alloc) throws Exce
engine.setUseClientMode(false);
- if (needClientAuth)
+ if (needClientAuth) {
engine.setNeedClientAuth(true);
+ }
+ if (wantClientAuth) {
--- End diff --
I would probably do this in an else as the setting would override the need
option and if someone did something silly like specify both I'd generally
prefer it chose the stronger of the two and setting want after need overrides
it.
> Support wantClientAuth on NettyAcceptor
> ---------------------------------------
>
> Key: ARTEMIS-1706
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1706
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.4.0
> Reporter: Christopher L. Shannon
> Assignee: Christopher L. Shannon
> Priority: Minor
> Fix For: 2.5.0
>
>
> Currently an acceptor can be configured for 2 way SSL authentication by
> setting needClientAuth to true. It is also useful to be able to set
> wantClientAuth to be true so that two way SSL is requested but isn't required.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
