[ 
https://issues.apache.org/jira/browse/ARTEMIS-1727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383789#comment-16383789
 ] 

ASF GitHub Bot commented on ARTEMIS-1727:
-----------------------------------------

GitHub user cshannon opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1925

    ARTEMIS-1727 - Make sure transport is stopped on failed OpenWire

    connection
    
    To prevent a socket from hanging open by a bad client the broker should
    make sure to stop the transport if a connection attempt fails by an
    OpenWire client

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cshannon/activemq-artemis ARTEMIS-1727

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1925.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1925
    
----
commit 8de2fccc883aa3a532e540e5e700e2c668e4e289
Author: Christopher L. Shannon (cshannon) <christopher.l.shannon@...>
Date:   2018-03-02T16:38:07Z

    ARTEMIS-1727 - Make sure transport is stopped on failed OpenWire
    connection
    
    To prevent a socket from hanging open by a bad client the broker should
    make sure to stop the transport if a connection attempt fails by an
    OpenWire client

----


> Broker should close socket on failed connection attempt using OpenWire
> ----------------------------------------------------------------------
>
>                 Key: ARTEMIS-1727
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1727
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: OpenWire
>    Affects Versions: 2.4.0
>            Reporter: Christopher L. Shannon
>            Assignee: Christopher L. Shannon
>            Priority: Major
>             Fix For: 2.5.0
>
>
> This is related to a patch I did for 5.x : AMQ-6561
> The OpenWire client will only close a connection failed connection attempt 
> automatically on a security error but not other JMSExceptions such as Invalid 
> client ids.  Because of this it's possible a misbehaving client can leave 
> open sockets that won't be closed.  The broker should detect a failed open 
> wire connection attempt and make sure the socket is killed.
> Note that the CORE client does not seem to have this problem because it does 
> properly handle all JMS exceptions on initial connect/authorization and close 
> itself.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to