[ https://issues.apache.org/jira/browse/ARTEMIS-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383833#comment-16383833 ]
ASF GitHub Bot commented on ARTEMIS-1724: ----------------------------------------- Github user johnpoth commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1922#discussion_r171908429 --- Diff: tests/karaf-client-integration-tests/pom.xml --- @@ -36,6 +36,18 @@ </properties> <dependencies> + <dependency> + <groupId>org.apache.activemq</groupId> + <artifactId>activemq-client</artifactId> + <scope>test</scope> + <exclusions> + <exclusion> + <!--Let's compile against JMS 2--> --- End diff -- Hi @jbertram thanks for reviewing! I'm excluding the JMS 1.1 artifact, so we are compiling against JMS 2 (which is brought on the classpath transitively by artemis-jms-client). It was causing compiling issues because javax.jms.Connection doesn't implement AutoCloseable in JMS 1.1 whereas it does in JMS 2 which makes it possible to use in try-with-resources statements. Thanks! > Create Artemis Openwire Client Karaf feature > -------------------------------------------- > > Key: ARTEMIS-1724 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1724 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: osgi > Affects Versions: 2.4.0 > Reporter: John Poth > Priority: Major > > It would be nice to have an Apache Karaf feature for an Openwire client. I > can take care of the PR. -- This message was sent by Atlassian JIRA (v7.6.3#76005)