Justin Bertram commented on ARTEMIS-528:

The lock is used by the CLI so it's really "above" the broker.  Therefore, it 
doesn't make a lot of sense to me to have the configuration for the lock 
directory in broker.xml.  A system property makes more sense.  However, there 
is a distinct danger in having this configurable since it would then be 
possible to ignore an existing lock simply by specifying a different directory 
(or worse, just getting it wrong).

Can you elaborate on your use-case a bit more?  Perhaps there is another way to 
accomplish your functional requirement.

> The "lock" directory should be configurable
> -------------------------------------------
>                 Key: ARTEMIS-528
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-528
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Lionel Cons
>            Priority: Major
> Artemis allows the broker owner to change most of the paths used, see for 
> instance the "*-directory" elements like "paging-directory". There is one 
> major exception though.
> The directory holding the {{cli.lock}} file is currently hard-coded in 
> {{artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Configurable.java}}
>  (sic):
> {code}
>    protected File getLockPlace() throws Exception {
>       String brokerInstance = getBrokerInstance();
>       if (brokerInstance != null) {
>          return new File(new File(brokerInstance),"lock");
>       }
>       else {
>          return null;
>       }
>    }
> {code}
> Could you please allow changing the name of this directory?
> Ideally, it could appear like the other "*-directory" elements in 
> {{broker.xml}}. If this is too late, it could come from a Java property such 
> as {{artemis.lockdir}}.

This message was sent by Atlassian JIRA

Reply via email to