[ 
https://issues.apache.org/jira/browse/ARTEMIS-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396837#comment-16396837
 ] 

ASF GitHub Bot commented on ARTEMIS-1743:
-----------------------------------------

GitHub user stanlyDoge opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1952

    ARTEMIS-1743 fix NPE in server log when Artemis trace logging is enabled

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stanlyDoge/activemq-artemis ARTEMIS-1743

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1952.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1952
    
----
commit 555dd31f60bacbfaf15cb559c8991c1e50618367
Author: Stanislav Knot <sknot@...>
Date:   2018-03-13T11:19:01Z

    ARTEMIS-1743 fix NPE in server log when Artemis trace logging is enabled

----


> NPE in server log when Artemis trace logging is enabled
> -------------------------------------------------------
>
>                 Key: ARTEMIS-1743
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1743
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.5.0
>            Reporter: Miroslav Novak
>            Assignee: Stanislav Knot
>            Priority: Major
>
> Artemis master (95b7438e7a7661692d5b78be944d05e254df9067) contains issue when 
> trace logging is enabled.
> If large message is sent and Artemis trace logs are enabled then following 
> NPE is logged in server log: 
> {code}
> 09:42:14,005 WARN  
> [org.apache.activemq.artemis.core.message.impl.CoreMessage] (default I/O-9) 
> Error creating String for message: : java.lang.NullPointerException
>     at 
> org.apache.activemq.artemis.core.message.impl.CoreMessage.encode(CoreMessage.java:584)
>     at 
> org.apache.activemq.artemis.core.message.impl.CoreMessage.checkEncode(CoreMessage.java:248)
>     at 
> org.apache.activemq.artemis.core.message.impl.CoreMessage.getEncodeSize(CoreMessage.java:647)
>     at 
> org.apache.activemq.artemis.core.message.impl.CoreMessage.getPersistentSize(CoreMessage.java:1157)
>     at 
> org.apache.activemq.artemis.core.message.impl.CoreMessage.toString(CoreMessage.java:1132)
>     at java.lang.String.valueOf(String.java:2994) [rt.jar:1.8.0_131]
>     at java.lang.StringBuilder.append(StringBuilder.java:131) 
> [rt.jar:1.8.0_131]
>     at 
> org.apache.activemq.artemis.core.protocol.core.impl.wireformat.SessionSendLargeMessage.toString(SessionSendLargeMessage.java:73)
>     at java.lang.String.valueOf(String.java:2994) [rt.jar:1.8.0_131]
>     at java.lang.StringBuilder.append(StringBuilder.java:131) 
> [rt.jar:1.8.0_131]
>     at 
> org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.bufferReceived(RemotingConnectionImpl.java:368)
>     at 
> org.apache.activemq.artemis.core.remoting.server.impl.RemotingServiceImpl$DelegatingBufferHandler.bufferReceived(RemotingServiceImpl.java:646)
>     at 
> org.apache.activemq.artemis.core.remoting.impl.netty.ActiveMQChannelHandler.channelRead(ActiveMQChannelHandler.java:68)
>     at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
>     at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
>     at 
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
>     at 
> io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:310)
>     at 
> io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:297)
>     at 
> io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:413)
>     at 
> io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:265)
>     at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
>     at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
>     at 
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
>     at 
> io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1359)
>     at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
>     at 
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
>     at 
> io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:935)
>     at 
> org.xnio.netty.transport.AbstractXnioSocketChannel$ReadListener.handleEvent(AbstractXnioSocketChannel.java:443)
>     at 
> org.xnio.netty.transport.AbstractXnioSocketChannel$ReadListener.handleEvent(AbstractXnioSocketChannel.java:379)
>     at 
> org.xnio.ChannelListeners.invokeChannelListener(ChannelListeners.java:92) 
> [xnio-api-3.6.1.Final.jar:3.6.1.Final]
>     at 
> org.xnio.conduits.ReadReadyHandler$ChannelListenerHandler.readReady(ReadReadyHandler.java:66)
>  [xnio-api-3.6.1.Final.jar:3.6.1.Final]
>     at org.xnio.nio.NioSocketConduit.handleReady(NioSocketConduit.java:89) 
> [xnio-nio-3.6.1.Final.jar:3.6.1.Final]
>     at org.xnio.nio.WorkerThread.run(WorkerThread.java:591) 
> [xnio-nio-3.6.1.Final.jar:3.6.1.Final]
> {code}
> Currently it appears that it has not impact on functionality but NPEs are 
> flooding server log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to