[
https://issues.apache.org/jira/browse/ARTEMIS-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407969#comment-16407969
]
ASF GitHub Bot commented on ARTEMIS-406:
----------------------------------------
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1960#discussion_r176095964
--- Diff:
artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompSession.java
---
@@ -154,12 +154,16 @@ public int sendMessage(MessageReference ref,
encoder.encode(buffer, bodySize);
encoder.close();
} else {
- buffer = coreMessage.getReadOnlyBodyBuffer();
+ if
(Boolean.TRUE.equals(serverMessage.getBooleanProperty(Message.HDR_LARGE_COMPRESSED)))
{
+ buffer = coreMessage.getBodyBuffer();
--- End diff --
this is because we need to decompress the content before send to clients.
If readonly we can't write into it.
> STOMP acknowledgements should support transactions
> --------------------------------------------------
>
> Key: ARTEMIS-406
> URL: https://issues.apache.org/jira/browse/ARTEMIS-406
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: STOMP
> Reporter: Lionel Cons
> Assignee: Howard Gao
> Priority: Major
>
> Artemis currently does not support transactional acknowledgements:
> {quote}
> Message acknowledgements are not transactional. The ACK frame can not be part
> of a transaction (it will be ignored if its transaction header is set).
> {quote}
> The STOMP 1.2 specification contains:
> {quote}
> Optionally, a transaction header MAY be specified, indicating that the
> message acknowledgment SHOULD be part of the named transaction.
> {quote}
> And other brokers (such as ActiveMQ 5.x) do support transactional
> acknowledgements.
> Artemis should support them too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
