[ 
https://issues.apache.org/jira/browse/ARTEMIS-1764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16409641#comment-16409641
 ] 

ASF GitHub Bot commented on ARTEMIS-1764:
-----------------------------------------

GitHub user mtaylor opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1968

    ARTEMIS-1764 Ignore Ack for Prepared Tx when Queue deleted

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mtaylor/activemq-artemis ARTEMIS-1764

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1968.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1968
    
----
commit f0bda8e6206d6651e7185449dc39a216ff4f6651
Author: Martyn Taylor <mtaylor@...>
Date:   2018-03-22T13:39:37Z

    ARTEMIS-1764 Ignore Ack for Prepared Tx when Queue deleted

----


> Broker does not start properly if prepared tx exists with ack to non existent 
> queue
> -----------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1764
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1764
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Martyn Taylor
>            Priority: Major
>
> A Tx exists with an ack or messagequeue X in prepared state.  If X is deleted 
> and the broker stopped and started.  The journal loader throws an exception 
> and the broker does not start properly.  Acceptors are not started etc...
>  
> 2018-03-22 13:35:07,149 WARN [org.apache.activemq.artemis.core.server] 
> AMQ222043: Message for queue 6,107,672 which does not exist. This message 
> will be ignored.
> 2018-03-22 13:35:07,152 ERROR [org.apache.activemq.artemis.core.server] 
> AMQ224000: Failure in initialisation: java.lang.IllegalStateException: Cannot 
> find queue with id 6107672
>  at 
> org.apache.activemq.artemis.core.server.impl.PostOfficeJournalLoader.handlePreparedAcknowledge(PostOfficeJournalLoader.java:306)
>  [artemis-server-2.6.0-SNAPSHOT.jar:2.6.0-SNAPSHOT]
>  at 
> org.apache.activemq.artemis.core.persistence.impl.journal.AbstractJournalStorageManager.loadPreparedTransactions(AbstractJournalStorageManager.java:1721)
>  [artemis-server-2.6.0-SNAPSHOT.jar:2.6.0-SNAPSHOT]
>  at 
> org.apache.activemq.artemis.core.persistence.impl.journal.AbstractJournalStorageManager.loadMessageJournal(AbstractJournalStorageManager.java:1169)
>  [artemis-server-2.6.0-SNAPSHOT.jar:2.6.0-SNAPSHOT]
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.loadJournals(ActiveMQServerImpl.java:2588)
>  [artemis-server-2.6.0-SNAPSHOT.jar:2.6.0-SNAPSHOT]
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.initialisePart2(ActiveMQServerImpl.java:2346)
>  [artemis-server-2.6.0-SNAPSHOT.jar:2.6.0-SNAPSHOT]
>  at 
> org.apache.activemq.artemis.core.server.impl.LiveOnlyActivation.run(LiveOnlyActivation.java:71)
>  [artemis-server-2.6.0-SNAPSHOT.jar:2.6.0-SNAPSHOT]
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.internalStart(ActiveMQServerImpl.java:522)
>  [artemis-server-2.6.0-SNAPSHOT.jar:2.6.0-SNAPSHOT]
>  at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.start(ActiveMQServerImpl.java:461)
>  [artemis-server-2.6.0-SNAPSHOT.jar:2.6.0-SNAPSHOT]
>  at 
> org.apache.activemq.artemis.integration.FileBroker.start(FileBroker.java:111) 
> [artemis-cli-2.6.0-SNAPSHOT.jar:2.6.0-SNAPSHOT]
>  at org.apache.activemq.artemis.cli.commands.Run.execute(Run.java:82) 
> [artemis-cli-2.6.0-SNAPSHOT.jar:2.6.0-SNAPSHOT]
>  at org.apache.activemq.artemis.cli.Artemis.internalExecute(Artemis.java:149) 
> [artemis-cli-2.6.0-SNAPSHOT.jar:2.6.0-SNAPSHOT]
>  at org.apache.activemq.artemis.cli.Artemis.execute(Artemis.java:97) 
> [artemis-cli-2.6.0-SNAPSHOT.jar:2.6.0-SNAPSHOT]
>  at org.apache.activemq.artemis.cli.Artemis.execute(Artemis.java:124) 
> [artemis-cli-2.6.0-SNAPSHOT.jar:2.6.0-SNAPSHOT]
>  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> [rt.jar:1.8.0_151]
>  at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> [rt.jar:1.8.0_151]
>  at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  [rt.jar:1.8.0_151]
>  at java.lang.reflect.Method.invoke(Method.java:498) [rt.jar:1.8.0_151]
>  at org.apache.activemq.artemis.boot.Artemis.execute(Artemis.java:129) 
> [artemis-boot.jar:2.6.0-SNAPSHOT]
>  at org.apache.activemq.artemis.boot.Artemis.main(Artemis.java:49) 
> [artemis-boot.jar:2.6.0-SNAPSHOT]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to