[ 
https://issues.apache.org/jira/browse/ARTEMIS-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417631#comment-16417631
 ] 

Justin Bertram commented on ARTEMIS-1769:
-----------------------------------------

The patch currently attached grabs the value for "jms-client-id" out of the 
core session's metadata and presents this as the core session's "clientID".  
However, this is not strictly accurate as it's conflating core & JMS sessions. 

In my opinion, the proper way to do this would be to represent the 
"jms-client-id" as what it actually is - core session metadata. The patch 
should just loop through the metadata (a method will need to be added to 
{{org.apache.activemq.artemis.core.server.impl.ServerSessionImpl}} to get the 
full metadata) and output the {{key=value}} pairs kind of like the way 
{{org.apache.activemq.artemis.core.server.impl.ServerSessionImpl#toString}} 
does.

> Return JMS Session's ClientID via JMX
> -------------------------------------
>
>                 Key: ARTEMIS-1769
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1769
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.5.0
>            Reporter: Maxim Kalina
>            Priority: Minor
>              Labels: patch
>             Fix For: 2.5.1
>
>         Attachments: return_jms_session's_clientID_via_JMX_if_exists.patch
>
>
> As discussed in the mailing list, currently there is no possibility to get 
> the JMS session's *clientID* via JMX.
>  
> I've attached the patch that extends the *ActiveMQServerControlImpl* and 
> *SessionView* classes to return the *clientID* if available.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to