[
https://issues.apache.org/jira/browse/ARTEMIS-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16419829#comment-16419829
]
ASF GitHub Bot commented on ARTEMIS-1778:
-----------------------------------------
GitHub user mohamnag opened a pull request:
https://github.com/apache/activemq-artemis/pull/1982
JUnit rules to be usable against external secured broker
as a companion to https://issues.apache.org/jira/browse/ARTEMIS-1778 this
will allow using junit rules to be used against an external secured broker.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mohamnag/activemq-artemis patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1982.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1982
----
commit c85f30fbaee6d44e2cd49f88c3c95339c98213d8
Author: Mohammad Naghavi <mohamnag@...>
Date: 2018-03-29T21:19:46Z
username and passowrd as part of junit rule
enable username and passowrd to be provided as part of junit rule
commit eee7e59442f307c620835d6cb0b400c3bb68c028
Author: Mohammad Naghavi <mohamnag@...>
Date: 2018-03-29T21:49:10Z
adding username and password for all junit rules
----
> let artemis test suite be used against an external security enabled broker
> --------------------------------------------------------------------------
>
> Key: ARTEMIS-1778
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1778
> Project: ActiveMQ Artemis
> Issue Type: Wish
> Affects Versions: 2.5.0
> Reporter: Mohammad Naghavi
> Priority: Major
>
> Using the clients provided in package artemis-junit against an externally
> running broker where security is enabled would be a great improvements in
> cases of end to end testing. Looking at the code of
> AbstractActiveMQClientResource, it is actually a pretty easy change, all
> needed is to let constructors accept optional username and password and to
> pass them to `sessionFactory.createSession()` where the session is being
> created on the start method.
> this easy change will enable a huge number of use cases for this helpful
> piece of code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
