[ 
https://issues.apache.org/jira/browse/ARTEMIS-1779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423221#comment-16423221
 ] 

ASF GitHub Bot commented on ARTEMIS-1779:
-----------------------------------------

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1984#discussion_r178669327
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionBridge.java
 ---
    @@ -127,9 +126,6 @@ public ClusterConnectionBridge(final ClusterConnection 
clusterConnection,
           this.managementNotificationAddress = managementNotificationAddress;
           this.flowRecord = flowRecord;
     
    -      // we need to disable DLQ check on the clustered bridges
    -      queue.setInternalQueue(true);
    --- End diff --
    
    Why did you change this?
    
    It seems it doesn't have any connection to your change.
    
    Beyond that.. we don't want any DLQ processing on internal queues from 
clustered bridge. This is a dangerous change.


> ClusterConnectionBridge may connect to other nodes than its target
> ------------------------------------------------------------------
>
>                 Key: ARTEMIS-1779
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1779
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 2.5.0
>            Reporter: Howard Gao
>            Assignee: Howard Gao
>            Priority: Major
>             Fix For: 2.5.1
>
>
> The cluster connection bridge has a TopologyListener and connects to a new 
> node each time it receives a nodeUp() event. It needs to put a check here to 
> make sure that the cluster bridge only connects to its target node and it's 
> backups.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to