[
https://issues.apache.org/jira/browse/ARTEMIS-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430660#comment-16430660
]
ASF GitHub Bot commented on ARTEMIS-1788:
-----------------------------------------
Github user dudaerich commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2003#discussion_r180127063
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/jdbc/JdbcNodeManager.java
---
@@ -95,18 +98,25 @@ public static JdbcNodeManager
with(DatabaseStorageConfiguration configuration,
}
}
- static JdbcNodeManager usingDataSource(String brokerId,
- long lockExpirationMillis,
- long lockRenewPeriodMillis,
- long
lockAcquisitionTimeoutMillis,
- long maxAllowedMillisFromDbTime,
- DataSource dataSource,
- SQLProvider provider,
- ScheduledExecutorService
scheduledExecutorService,
- ExecutorFactory executorFactory,
- IOCriticalErrorListener
ioCriticalErrorListener) {
+ private static JdbcNodeManager usingDataSource(String brokerId,
+ long networkTimeout,
+ long
lockExpirationMillis,
+ long
lockRenewPeriodMillis,
+ long
lockAcquisitionTimeoutMillis,
+ long
maxAllowedMillisFromDbTime,
+ DataSource dataSource,
+ SQLProvider provider,
+ ScheduledExecutorService
scheduledExecutorService,
+ ExecutorFactory
executorFactory,
+ IOCriticalErrorListener
ioCriticalErrorListener) {
return new JdbcNodeManager(
- () -> JdbcSharedStateManager.usingDataSource(brokerId,
lockExpirationMillis, maxAllowedMillisFromDbTime, dataSource, provider),
+ () -> JdbcSharedStateManager.usingDataSource(brokerId,
+ (int) networkTimeout,
--- End diff --
Why don't you pass here long but you retype it to int?
> JDBC HA should use JDBC Network Timeout
> ---------------------------------------
>
> Key: ARTEMIS-1788
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1788
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.5.0
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Major
> Fix For: 2.5.1
>
>
> The JDBC Node Manager doesn't use the JDBC Network Timeout used on the rest
> of the Journal.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
