[ 
https://issues.apache.org/jira/browse/ARTEMIS-1790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432223#comment-16432223
 ] 

ASF GitHub Bot commented on ARTEMIS-1790:
-----------------------------------------

Github user stanlyDoge commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1999#discussion_r180413588
  
    --- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java
 ---
    @@ -511,6 +511,45 @@ public final boolean isUsingProtocolHandling() {
           return true;
        }
     
    +   @Override
    +   public boolean isSameTarget(TransportConfiguration... configs) {
    +      boolean yes = false;
    --- End diff --
    
    hehehe


> Improve Topology Member Finding
> -------------------------------
>
>                 Key: ARTEMIS-1790
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1790
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.5.0
>            Reporter: Howard Gao
>            Assignee: Howard Gao
>            Priority: Major
>             Fix For: 2.5.1
>
>
> When finding out if a connector belong to a target node it compares the whole 
> parameter map which is not necessary. Also in understanding the connector the 
> best place is to delegate it to the corresponding remoting connection who 
> understands it. (e.g. INVMConnection knows whether the connector belongs to a 
> target node by checking it's serverID only. The netty ones only need to match 
> host and port, and understanding that localhost and 127.0.0.1 are same thing).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to