[ https://issues.apache.org/jira/browse/ARTEMIS-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432398#comment-16432398 ]
ASF GitHub Bot commented on ARTEMIS-1799: ----------------------------------------- Github user cshannon commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2007#discussion_r180449915 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java --- @@ -39,7 +39,15 @@ PROPOSAL(18), PROPOSAL_RESPONSE(19), UNPROPOSAL(20), - CONSUMER_SLOW(21); + CONSUMER_SLOW(21), + ADDRESS_ADDED(22), + ADDRESS_REMOVED(23), + CONNECTION_CREATED(24), + CONNECTION_DESTROYED(25), + SESSION_CREATED(26), + SESSION_CLOSED(27), + MESSAGE_DELIVERED(28), --- End diff -- No because every notification is off by default. The user can configure what they want. By default if you configure the plugin it doesn't do anything unless the user sets a type to true to send. So if someone doesn't care about message delivered notifications then just leave that flag as false. > Create a NotificationActiveMQServerPlugin to publish new types of > notifications > ------------------------------------------------------------------------------- > > Key: ARTEMIS-1799 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1799 > Project: ActiveMQ Artemis > Issue Type: New Feature > Components: Broker > Affects Versions: 2.5.0 > Reporter: Christopher L. Shannon > Assignee: Christopher L. Shannon > Priority: Major > Fix For: 2.6.0 > > > For monitoring the broker it would be helpful to support publishing of new > notification types that can be listened for. This is similar to the > advisories that ActiveMQ 5.x supports. > By adding this functionality to a plugin it can be easily enabled/disabled by > the user through configuration and fine tuned to a user's requirements. For > this initial Jira I'm proposing adding the following notification types: > connection creation/destroyed events, session created/closed events, address > added/removed events, delivered messages, and expired messages. > It will be easy to enhance these new notifications in future Jiras (ie add > more properties to the messages if necessary) and also easy to add new > notifications to the plugin. -- This message was sent by Atlassian JIRA (v7.6.3#76005)