[
https://issues.apache.org/jira/browse/ARTEMIS-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434404#comment-16434404
]
ASF GitHub Bot commented on ARTEMIS-1801:
-----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2010#discussion_r180859972
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -2727,7 +2731,7 @@ private Message makeCopy(final MessageReference ref,
Message copy = message.copy(newID);
if (copyOriginalHeaders) {
- copy.referenceOriginalMessage(message, ref != null ?
ref.getQueue().getName().toString() : null);
+ copy.referenceOriginalMessage(message,
ref.getQueue().getName().toString());
--- End diff --
keep it ! :) nice one!
> Remove dereferences before null check
> -------------------------------------
>
> Key: ARTEMIS-1801
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1801
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Stanislav Knot
> Assignee: Stanislav Knot
> Priority: Minor
>
> There are some dereferences before object is checked for null.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
