[ 
https://issues.apache.org/jira/browse/ARTEMIS-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435548#comment-16435548
 ] 

ASF GitHub Bot commented on ARTEMIS-1803:
-----------------------------------------

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2012
  
    Sorry to be a numpty but why this needs to be held in memory? Is it going 
to be used for processing the flow in broker.
    
    From an admin point even if the message is paged, if a browser or admin 
needs it simply get it from the message (reading out of paging) 
    
    Less stuff having to hold in memory better perf.
    
    I’m a little against this if there’s no processing need for this. 


> MessageReference should include sessionId
> -----------------------------------------
>
>                 Key: ARTEMIS-1803
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1803
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>    Affects Versions: 2.5.0
>            Reporter: Christopher L. Shannon
>            Assignee: Christopher L. Shannon
>            Priority: Minor
>
> Right now a MessageReference will track a consumerId (in certain scenarios) 
> but the sessionId is not included.  This is a problem because consumerIds are 
> not unique and are duplicated across sessions.  In order to find a unique 
> consumer you need the sessionId and consumerId as well. 
> A use case for when this is important is when writing custom plugins.  Some 
> of the callbacks pass a message reference and it would be good to be able to 
> figure out which consumer the reference belonged to such as in the 
> messageAcknowledged callback.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to