[ 
https://issues.apache.org/jira/browse/ARTEMIS-1812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439470#comment-16439470
 ] 

ASF GitHub Bot commented on ARTEMIS-1812:
-----------------------------------------

GitHub user stanlyDoge opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2020

    ARTEMIS-1812 fix for missing (core) messages after master kill (HA)

    When I try to send some core messages to slave broker (master is dead), 
messages are lost. Debug console says "Couldn't find any bindings for 
address=TEST.foo". By digging into code, I think this is the spot, which is 
responsible for this bug: 
https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java#L832
 
    
    I have tried to create queue with default values here. It fixes the bug, 
but i am afraid it can create much more new bugs. Git blame says 
@clebertsuconic and @jbertram could know more about this. Can you guys please 
approve/disprove this fix? If it is ok, please do not merge, I would like to 
bring some test for this and delete comments. Thank you.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stanlyDoge/activemq-artemis ARTEMIS-1812

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2020.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2020
    
----
commit 688397ea74897d5ad49d4694a74c14849148b8de
Author: Stanislav Knot <sknot@...>
Date:   2018-04-16T13:46:22Z

    ARTEMIS-1812 fix for missing (core) messages after master kill (HA)

----


> [core] Any Subsequent messages are lost after queue is emptied from slave 
> broker (succ failover from master kill)
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1812
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1812
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>         Environment: single HA pair - failover to slave
> Core protocol
>            Reporter: Stanislav Knot
>            Assignee: Stanislav Knot
>            Priority: Blocker
>
> # Form HA pair (with auto-create)
>  # Send 10 messages via Core protocol
>  # Kill master broker
>  # Receive 10 messages from this Core queue
>  # Observe that queue is removed, but address is present (via hawtio f.e.)
>  # Send few messages to this Core queue again -> No messages are received by 
> broker, they seem to be lost in time & space



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to