[
https://issues.apache.org/jira/browse/ARTEMIS-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16441042#comment-16441042
]
ASF GitHub Bot commented on ARTEMIS-1781:
-----------------------------------------
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1987
@TomasHofman Kudos.. really nice...
i have done some tweaking though.. I'm removing TransportConstantsV2 and
adding those properties directly on the Utility.. the TransportConstantsV2 name
would be confusing and people would think that's the newest version to be
used...
I have also split your commit into 2.. one for the tests and one for the
fix... but I kept you the authorship.
I'm merging these myself as I don't see a point on going back and forth
asking you to make these chagnes as I have them already...
I will apologize in advance as I'm pushing I change I made into your commit
(removing the V2 class) but the github would be simpler if I amended my change
into yours.. consider it like I have asked you to make the change and it's been
done..
I'm merging it now.. but please check if you see anything wrong after I
merged it.
> Broken backward compatibility with HornetQ
> ------------------------------------------
>
> Key: ARTEMIS-1781
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1781
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 1.5.5, 2.5.0
> Reporter: Tomas Hofman
> Priority: Major
>
> When connector is configured to use SSL encryption, HornetQ client receives
> invalid parameter keys - camelCase instead of dash-separated.
> {code:java}
> 2018-01-23 17:39:32,769 logLev=WARN class=org.hornetq.jms.server
> thread="Periodic Recovery" HQ122015: Can not connect to XARecoveryConfig
> [transportConfiguration = [TransportConfiguration(name=hornetq-ssl-connector,
> factory=org-hornetq-core-remoting-impl-netty-NettyConnectorFactory)
> ?trustStorePassword=123456&keyStorePassword=123456&port=5500&sslEnabled=true&host=ld9c02ad-umobi-mobicorp-test&trustStorePath=/data/jboss/server/mobi/configuration/keys/jspStore_dev-jks&keyStorePath=/data/jboss/server/mobi/configuration/keys/mobiJspDynWesTrust_dev-jks],
> discoveryConfiguration = null, username=Z100283, password=****] on
> auto-generated resource recovery: java.lang.IllegalStateException: The
> following keys are invalid for configuring a connector: trustStorePassword,
> keyStorePassword, sslEnabled, trustStorePath, keyStorePath
> at
> org.hornetq.core.client.impl.ClientSessionFactoryImpl.checkTransportKeys(ClientSessionFactoryImpl.java:1542)
> at
> org.hornetq.core.client.impl.ClientSessionFactoryImpl.<init>(ClientSessionFactoryImpl.java:212)
> at
> org.hornetq.core.client.impl.ServerLocatorImpl.createSessionFactory(ServerLocatorImpl.java:872)
> at
> org.hornetq.jms.server.recovery.HornetQXAResourceWrapper.connect(HornetQXAResourceWrapper.java:377)
> at
> org.hornetq.jms.server.recovery.HornetQXAResourceWrapper.getDelegate(HornetQXAResourceWrapper.java:286)
> at
> org.hornetq.jms.server.recovery.HornetQXAResourceWrapper.recover(HornetQXAResourceWrapper.java:74)
> at
> com.arjuna.ats.internal.jta.recovery.arjunacore.XARecoveryModule.xaRecoveryFirstPass(XARecoveryModule.java:541)
> at
> com.arjuna.ats.internal.jta.recovery.arjunacore.XARecoveryModule.periodicWorkFirstPass(XARecoveryModule.java:181)
> at
> com.arjuna.ats.internal.arjuna.recovery.PeriodicRecovery.doWorkInternal(PeriodicRecovery.java:747)
> at
> com.arjuna.ats.internal.arjuna.recovery.PeriodicRecovery.run(PeriodicRecovery.java:375)
> {code}
> Original issue: https://issues.jboss.org/browse/ENTMQBR-1034
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
