[ 
https://issues.apache.org/jira/browse/ARTEMIS-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474211#comment-16474211
 ] 

ASF GitHub Bot commented on ARTEMIS-1866:
-----------------------------------------

Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2089#discussion_r187950231
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/qourum/SharedNothingBackupQuorum.java
 ---
    @@ -297,7 +300,7 @@ private boolean isLiveDown() {
                 quorumManager.vote(quorumVote);
     
                 try {
    -               quorumVote.await(LATCH_TIMEOUT, TimeUnit.SECONDS);
    +               quorumVote.await(quorumVoteWait, TimeUnit.SECONDS);
                 } catch (InterruptedException interruption) {
                    // No-op. The best the quorum can do now is to return the 
latest number it has
    --- End diff --
    
    Please add some trace logs before the `await` and on the catch scope to log 
that the awaut has been interrupted


> Make wait time for reply configurable once vote goes out to acquire a quorum.
> -----------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1866
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1866
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.5.0
>            Reporter: Saurabh Rai
>            Priority: Major
>
> Whenever a vote goes out from a broker to acquire a quorum there's a 
> hard-coded 30-second wait for the reply. We should change this 30-second wait 
> to be configurable.
> Please find the logs for reference:
> 2018-05-06 11:20:42,906 INFO [org.apache.activemq.artemis.core.server] 
> AMQ221066: Initiating quorum vote: LiveFailoverQuorumVote 2018-05-06 
> 11:20:42,906 INFO [org.apache.activemq.artemis.core.server] AMQ221067: 
> Waiting 30 seconds for quorum vote results. 2018-05-06 11:20:42,914 INFO 
> [org.apache.activemq.artemis.core.server] AMQ221060: Sending quorum vote 
> request to amq2a/10.92.151.33:61716: ServerConnectVote 
> [nodeId=d41a0e0f-50da-11e8-9b2d-005056b01f85, vote=false]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to