[ 
https://issues.apache.org/jira/browse/ARTEMIS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477004#comment-16477004
 ] 

ASF GitHub Bot commented on ARTEMIS-1868:
-----------------------------------------

Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2090#discussion_r188532813
  
    --- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java
 ---
    @@ -95,6 +97,8 @@
     
        private final SimpleString clientId;
     
    +   private final Set<Long> rollbackedIds = new ConcurrentHashSet<>();
    --- End diff --
    
    It could belong to `AMQConsumer` instead of here? That will make it less 
contended, because owned exclusively by the consumer 


> Openwire doesn't add delivery count in client ack mode
> ------------------------------------------------------
>
>                 Key: ARTEMIS-1868
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1868
>             Project: ActiveMQ Artemis
>          Issue Type: Test
>          Components: OpenWire
>    Affects Versions: 2.5.0
>            Reporter: Howard Gao
>            Assignee: Howard Gao
>            Priority: Major
>             Fix For: 2.5.1
>
>
> If a client ack mode consumer receives a message and closes without acking 
> it, the redelivery of the message won't set the redelivery flag 
> (JMSRedelivered) because it doesn't increment the delivery count when message 
> is cancelled back to queue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to