[ 
https://issues.apache.org/jira/browse/ARTEMIS-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478972#comment-16478972
 ] 

ASF GitHub Bot commented on ARTEMIS-1866:
-----------------------------------------

Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2089
  
    @RaiSaurabh We have an [hacking 
guide](https://activemq.apache.org/artemis/docs/latest/hacking-guide/code.html) 
that explain:
    
    > When you commit your changes you will need to supply a commit message. We 
follow the 50/72 git commit message format. An ActiveMQ Artemis commit message 
should be formatted in the following manner:
    > 
    > Add the ARTEMIS JIRA (if one exists) followed by a brief description of 
the change in the first line. This line should be limited to 50 characters.
    > Insert a single blank line after the first line.
    > Provide a detailed description of the change in the following lines, 
breaking paragraphs where needed. These lines should be wrapped at 72 
characters.
    > An example correctly formatted commit message:
    > 
    >   ARTEMIS-123 Add new commit msg format to README
    > 
    >   Adds a description of the new commit message format as well as examples
    >   of well formatted commit messages to the README.md.  This is required 
    >   to enable developers to quickly identify what the commit is intended to 
    >   do and why the commit was added.


> Make wait time for reply configurable once vote goes out to acquire a quorum.
> -----------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1866
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1866
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.5.0
>            Reporter: Saurabh Rai
>            Priority: Major
>
> Quorum voting is used by both the live and the backup to decide what to do if 
> a replication connection is disconnected. Basically, the server will request 
> each live server in the cluster to vote as to whether it thinks the server it 
> is replicatingĀ to or from is still alive. You can also configure the time for 
> which the quorum manager will wait for the quorum vote response. Currently, 
> the value is hardcoded asĀ 30 sec. We should change this 30-second wait to be 
> configurable.
> Please find the logs for reference:
> 2018-05-06 11:20:42,906 INFO [org.apache.activemq.artemis.core.server] 
> AMQ221066: Initiating quorum vote: LiveFailoverQuorumVote 2018-05-06 
> 11:20:42,906 INFO [org.apache.activemq.artemis.core.server] AMQ221067: 
> Waiting 30 seconds for quorum vote results. 2018-05-06 11:20:42,914 INFO 
> [org.apache.activemq.artemis.core.server] AMQ221060: Sending quorum vote 
> request to amq2a/10.92.151.33:61716: ServerConnectVote 
> [nodeId=d41a0e0f-50da-11e8-9b2d-005056b01f85, vote=false]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to