[
https://issues.apache.org/jira/browse/ARTEMIS-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483410#comment-16483410
]
ASF GitHub Bot commented on ARTEMIS-1872:
-----------------------------------------
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2093
These following tests are failing:
Test Result (14 failures / +14)
org.apache.activemq.artemis.tests.integration.amqp.JMSConnectionWithSecurityTest.testCreateTemporaryQueueNotAuthorized
org.apache.activemq.artemis.tests.integration.amqp.JMSConnectionWithSecurityTest.testCreateTemporaryTopicNotAuthorized
org.apache.activemq.artemis.tests.integration.jms.consumer.JmsConsumerTest.testValidateExceptionsThroughSharedConsumers
org.apache.activemq.artemis.tests.integration.jms.jms2client.SharedConsumerTest.sharedNonDurableSubOnDifferentSelector
org.apache.activemq.artemis.tests.integration.jms.jms2client.SharedConsumerTest.sharedDurableSubOnDifferentSelector
org.apache.activemq.artemis.tests.integration.jms.jms2client.SharedConsumerTest.sharedDurableSubOnDifferentTopic
org.apache.activemq.artemis.tests.integration.jms.jms2client.SharedConsumerTest.sharedNonDurableSubOnDifferentSelectorSrcFilterNull
org.apache.activemq.artemis.tests.integration.jms.jms2client.SharedConsumerTest.sharedDurableSubOnDifferentSelectorSrcFilterNull
org.apache.activemq.artemis.tests.integration.jms.jms2client.SharedConsumerTest.sharedDurableSubOnDifferentSelectorTargetFilterNull
org.apache.activemq.artemis.tests.integration.jms.jms2client.SharedConsumerTest.sharedNonDurableSubOnDifferentSelectorTargetFilterNull
These tests also failed when I ran but they are probably part of the
intermittent failures:
org.apache.activemq.artemis.protocol.amqp.util.CreditsSemaphoreTest.testDownAndUp
org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedLargeMessageWithDelayFailoverTest.testFailThenReceiveMoreMessagesAfterFailover2
org.apache.activemq.artemis.tests.integration.cluster.reattach.MultiThreadRandomReattachTest.testD
org.apache.activemq.artemis.tests.integration.cluster.reattach.NettyMultiThreadRandomReattachTest.testE
(Although I believe CreditsSemaphoreTest failed because of these changes..
I'm not 100% sure)
> Correctly check for queue exists before creating shared queue
> -------------------------------------------------------------
>
> Key: ARTEMIS-1872
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1872
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Michael Andre Pearce
> Priority: Major
>
> Prior to 2.5.0, artemis incorrectly always checked the perms for Non Durable
> on createSharedQueue , even if the queue being created was a Durable queue.
> securityCheck(address, name, CheckType.*_CREATE_NON_DURABLE_QUEUE_*, *this*);
>
> In 2.5.0+ this has been corrected, so it checks the permissions appropriately
> for the durability.
> securityCheck(address, name, durable ? CheckType.*_CREATE_DURABLE_QUEUE_* :
> CheckType.*_CREATE_NON_DURABLE_QUEUE_*, *this*);
>
> This though has exposed that in some area's of the Core client code, and also
> AMQP, and OpenWire that the code isn't checking that queue exists before
> calling to create it, meaning a client with consume permission but without
> create durable queue permissions, would fail but should not as the queue
> exists.
> Also it was noted on creating the test case to prove this that AMQP JMS
> Client when security exception occurs, was not correctly throwing
> JMSSecurityException, this is due to the broker not returning the correct
> AMQP error code, in these circumstances.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
