[ https://issues.apache.org/jira/browse/ARTEMIS-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510216#comment-16510216 ]
ASF GitHub Bot commented on ARTEMIS-1927: ----------------------------------------- Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2139#discussion_r194890149 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/server/impl/RemotingServiceImpl.java --- @@ -554,20 +558,13 @@ public void connectionDestroyed(final Object connectionID) { return; } } - conn.connection.fail(new ActiveMQRemoteDisconnectException()); + conn.connection.fail(e); } } @Override public void connectionException(final Object connectionID, final ActiveMQException me) { - // We DO NOT call fail on connection exception, otherwise in event of real connection failure, the - // connection will be failed, the session will be closed and won't be able to reconnect - - // E.g. if live server fails, then this handler wil be called on backup server for the server - // side replicating connection. - // If the connection fail() is called then the sessions on the backup will get closed. - - // Connections should only fail when TTL is exceeded + issueFailure(connectionID, me); } --- End diff -- Does this comment no longer apply? Is there not a risk that core clients won't be able to reconnect to their server session in the case of a spurious network failure? > Server is not disconnecting clients on connection reset by peer > --------------------------------------------------------------- > > Key: ARTEMIS-1927 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1927 > Project: ActiveMQ Artemis > Issue Type: Bug > Affects Versions: 2.6.1 > Environment: This is specific to windows. if you close a connection > by CTRL-C a disconnect is not sent some times. > > The server could treat the exception thrown by netty accordingly. > Reporter: clebert suconic > Priority: Major > Fix For: 2.7.0, 2.6.2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)