[
https://issues.apache.org/jira/browse/ARTEMIS-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16536929#comment-16536929
]
ASF GitHub Bot commented on ARTEMIS-1941:
-----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2174#discussion_r201004508
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/converter/message/JMSMappingOutboundTransformerTest.java
---
@@ -361,7 +361,7 @@ public void
testConvertEmptyObjectMessageToAmqpMessageWithAmqpValueBody() throws
assertNotNull(amqp.getBody());
assertTrue(amqp.getBody() instanceof AmqpValue);
assertTrue(((AmqpValue) amqp.getBody()).getValue() instanceof
Binary);
- assertEquals(0, ((Binary) ((AmqpValue)
amqp.getBody()).getValue()).getLength());
+ assertEquals(5, ((Binary) ((AmqpValue)
amqp.getBody()).getValue()).getLength());
--- End diff --
@tabish121 what about reverting the change on the AMQP converter and just
avoid the conversion? This will only be relevant if converting back to AMQP, so
not converting to Core just because of large messages would be the best choice.
> broker changes AMQP body section type during 'Large' message handling
> ---------------------------------------------------------------------
>
> Key: ARTEMIS-1941
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1941
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
> Affects Versions: 2.6.1
> Reporter: Robbie Gemmell
> Priority: Major
>
> When the broker receives AMQP messages it considers those over a certain size
> (currently the lower of journal file size and journal buffer size, ~500KB
> default) to be a 'large' message. In its handling of these, the message is
> essentially converted internally to a Core message, and when sending the
> message to an AMQP consumer, essentially gets converted back. During
> investigation of and testing of ARTEMIS-1940 I noted that although my test
> sent in an AMQP Data body section and so that is what should come back out, I
> instead received an AMQP Value body section containing a binary value (with
> the same bytes).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
