[ 
https://issues.apache.org/jira/browse/ARTEMIS-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16537233#comment-16537233
 ] 

ASF GitHub Bot commented on ARTEMIS-856:
----------------------------------------

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2175#discussion_r201073066
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
 ---
    @@ -270,6 +271,15 @@
     
        private final QueueFactory factory;
     
    +   private final AtomicBoolean dispatching = new AtomicBoolean();
    --- End diff --
    
    I wanted that when dispatching the quickest eval is done, thus why the 
seperate boolean. As it is hot path. Agree could just use != -1 check, memory 
vs cpu cycle. Let me know your thought 
    
    Agree re atomic updater, i can make this change. 


> Support advanced destination options
> ------------------------------------
>
>                 Key: ARTEMIS-856
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-856
>             Project: ActiveMQ Artemis
>          Issue Type: New Feature
>          Components: Broker
>            Reporter: Matt Pavlovich
>            Priority: Major
>
> Add support enhancing destination consumer features (ActiveMQ 5.x parity):
> consumersBeforeDispatchStarts
>  timeBeforeDispatchStarts
> [http://activemq.apache.org/per-destination-policies.html]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to