[ 
https://issues.apache.org/jira/browse/ARTEMIS-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554384#comment-16554384
 ] 

ASF GitHub Bot commented on ARTEMIS-1985:
-----------------------------------------

GitHub user graben opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2193

    ARTEMIS-1985: Switch from XA_RDONLY to XA_OK as return value for prepare 
transaction via OpenWire

    @clebertsuconic : Feedback for possible test cases needed 
(https://issues.apache.org/jira/browse/ARTEMIS-1985)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/graben/activemq-artemis ARTEMIS-1985

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2193.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2193
    
----
commit 75b20b6553b374950dac333a1350783f0d29f937
Author: Benjamin Graf <benjamin.graf@...>
Date:   2018-07-21T14:57:12Z

    ARTEMIS-1985: Switch from XA_RDONLY to XA_OK as return value for prepare 
transaction via OpenWire

----


> Produced message via OpenWire does not get committed in XA transaction
> ----------------------------------------------------------------------
>
>                 Key: ARTEMIS-1985
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1985
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: OpenWire
>    Affects Versions: 2.6.2
>            Reporter: Benjamin Graf
>            Priority: Critical
>             Fix For: 2.7.0, 2.6.3
>
>
> OpenWireConnection actually does return RDONLY as result for prepare. This 
> state causes transaction manager to ignore resource in a 2pc commit. It 
> should be XA_OK as returned by core protocol and ActiveMQ broker.
> To validate you need a XA transaction with min. 2 resources to force 
> transaction manager to not optimize commit to 1pc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to