[
https://issues.apache.org/jira/browse/ARTEMIS-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566679#comment-16566679
]
Martyn Taylor commented on ARTEMIS-1493:
----------------------------------------
Just came across this issue. The only reason to use long over int for
milliseconds is if the sensible range of the millisecond value goes beyond
Integer.MAX. In this case, it's not. The JDBC API is reflected by this.
> DatabaseStorageConfiguration API is not consistent
> --------------------------------------------------
>
> Key: ARTEMIS-1493
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1493
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.4.0
> Reporter: Jeff Mesnil
> Priority: Trivial
>
> The setJdbcNetworkTimeout(int jdbcNetworkTimeout) method is not correct. It
> expects a value in milliseconds but accepts only an int instead of a long.
> The name is also not consistent with the new methods
> setJdbcLockRenewPeriodMillis(), setJdbcLockExpirationMillis(),
> setJdbcLockAcquisitionTimeoutMillis() that appends Millis to specify the time
> unit and accepts long parameters.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
