[ 
https://issues.apache.org/jira/browse/ARTEMIS-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571919#comment-16571919
 ] 

ASF GitHub Bot commented on ARTEMIS-2014:
-----------------------------------------

Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2222#discussion_r208297490
  
    --- Diff: 
artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/AbstractSequentialFileFactory.java
 ---
    @@ -224,8 +224,10 @@ public void releaseBuffer(final ByteBuffer buffer) {
        @Override
        public void createDirs() throws Exception {
           boolean ok = journalDir.mkdirs();
    -      if (!ok) {
    -         throw new IOException("Failed to create directory " + journalDir);
    +      if (!ok && !journalDir.exists()) {
    --- End diff --
    
    If the directory already exists then `mkdirs()` will return false, but that 
shouldn't be treated as an error therefore the `if` tests both conditions.


> Treat inability to create directory for paging as critial
> ---------------------------------------------------------
>
>                 Key: ARTEMIS-2014
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2014
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 2.6.2
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to