[
https://issues.apache.org/jira/browse/ARTEMIS-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574813#comment-16574813
]
ASF GitHub Bot commented on ARTEMIS-2019:
-----------------------------------------
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/2231
ARTEMIS-2019 - Seperate ServerPlugin Interfaces
Seperate plugin interface by area, all extending a base interface.
Update code to check and call only plugins implementing specific interfaces.
Existing interface extends all the new interfaces for back compatibility or
those who want simplicity and don't care about perf.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelandrepearce/activemq-artemis
SeperatePlugins
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2231.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2231
----
commit 09980c2d5cbce5eae5c06ef963e03d68a674bdd3
Author: Michael André Pearce <michael.andre.pearce@...>
Date: 2018-08-09T12:43:45Z
ARTEMIS-2019 - Seperate ServerPlugin Interfaces
Seperate plugin interface by area, all extending a base interface.
Update code to check and call only plugins implementing specific interfaces.
Existing interface extends all the new interfaces for back compatibility or
those who want simplicity and don't care about perf.
----
> Refactor Artemis ServerPlugin to Seperate concerns
> --------------------------------------------------
>
> Key: ARTEMIS-2019
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2019
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Michael Andre Pearce
> Priority: Major
>
> Currently ServerPlugins all have to implement ActiveMQServerPlugin which
> means if someone wants to have a plugin to get a callback say on connection,
> it will mean else where on hot paths where a check is done to eliminate
> overhead, the plugin will be called even if the user doesnt want it to be.
> As such refactor to separate interfaces by plugin area so that users can
> implement just the area they wish without needing to worry about it impacting
> other areas.
>
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
