[ 
https://issues.apache.org/jira/browse/ARTEMIS-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16575139#comment-16575139
 ] 

Jeff Mesnil commented on ARTEMIS-1206:
--------------------------------------

> whereas the former is implied and stated in the Javadoc 

Where is it written?

> there are certainly references to that behaviour within the JMS spec process 
> itself

Which ones? I did not find any other mention of the ClientID that was is 
already in the Connection.setClientID() javadoc.

>  I dont read from the spec that restrictions on duplicate ClientIDs only 
> applies to uses of setClientID, but rather the restriction is on the value of 
> ClientIDs in use on any connection and not just those which called 
> setClientID.

Where do you read that?

What's more, the test in the PR is not asserting what the spec says.
The javadoc of 
https://docs.oracle.com/javaee/7/api/javax/jms/Connection.html#setClientID-java.lang.String-
 is quite clear.
It throws InvalidClientIDException if the JMS client specifies an invalid or 
duplicate client ID.

The test asserts that createConnection() throws an InvalidClientIDException the 
2nd time a ConnectionFactory with a configured CF create a connection. That's 
totally different.



> [Core JMS Client] Violates JMS Specification - allows two active connections 
> with same clientid
> -----------------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1206
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1206
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 2.1.0
>            Reporter: Michael Andre Pearce
>            Assignee: clebert suconic
>            Priority: Major
>             Fix For: 2.2.0
>
>         Attachments: JMSDurableConsumerTest2.java, 
> JMSDurableConsumerTest2.java
>
>
> Currently it is possible to make two completely separate client connections 
> to the broker, with the same client id.
> This was found/raised as a possible bug in Core Client on looking at 
> differing behaviours between the Core JMS Client and the Qpid AMQP Client.
> https://issues.apache.org/jira/browse/ARTEMIS-1205
> Attached is a test case, where by the Qpid Client errors, and the Core Client 
> does not, executing the same client code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to