[
https://issues.apache.org/jira/browse/ARTEMIS-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578517#comment-16578517
]
ASF GitHub Bot commented on ARTEMIS-2029:
-----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2247#discussion_r209666896
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java
---
@@ -638,13 +638,9 @@ public synchronized CoreMessage encode() {
checkProperties();
- if (writableBuffer != null) {
--- End diff --
ouch.. don't merge this.. didn't mean this change!!!!
> Reconnects will break version compatibility checks when reconnecting to older
> versions
> --------------------------------------------------------------------------------------
>
> Key: ARTEMIS-2029
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2029
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.6.2
> Reporter: clebert suconic
> Assignee: clebert suconic
> Priority: Major
> Fix For: 2.7.0, 2.6.3
>
>
> When you reconnect the old version is not passed on the new connection
> created.
> Resulting in wire breakage when using version checks on the wire.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
