[
https://issues.apache.org/jira/browse/ARTEMIS-2024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578553#comment-16578553
]
ASF GitHub Bot commented on ARTEMIS-2024:
-----------------------------------------
Github user mtaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2246#discussion_r209671702
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/ConnectionTest.java
---
@@ -131,6 +131,27 @@ public void testTwoConnectionsSameIDThroughCF() throws
Exception {
session2.close();
}
+ @Test
+ public void testTwoConnectionsSameIDThroughCFWithShareClientIDEnabeld()
throws Exception {
+ ActiveMQConnectionFactory connectionFactory = new
ActiveMQConnectionFactory("tcp://localhost:61616?clientID=myid;enableSharedClientID=true");
+
+ conn = connectionFactory.createConnection();
+ try {
+ conn2 = connectionFactory.createConnection();
+ } catch (InvalidClientIDException expected) {
+ Assert.fail("Should allow sharing of client IDs among the same
CF");
+ }
+
+ Session session1 = conn.createSession();
+ Session session2 = conn.createSession();
--- End diff --
Yes. Copy and paste error ;). Will fix.
> Enable backwards compatability of shared client ID across ConnectionFactories
> -----------------------------------------------------------------------------
>
> Key: ARTEMIS-2024
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2024
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Martyn Taylor
> Priority: Critical
>
> The fix around the JMS violation to ensure Client IDs are not shared across
> connections breaks compatability with existing users in particular usages
> within the WildFly application server. In order to continue support we
> should add a configuration option to enable the old behaviour across the
> ConnectionFactories and within the RA.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
