[
https://issues.apache.org/jira/browse/ARTEMIS-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16580823#comment-16580823
]
ASF GitHub Bot commented on ARTEMIS-2023:
-----------------------------------------
Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2249#discussion_r210198098
--- Diff:
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/impl/ConnectionFactoryConfigurationImpl.java
---
@@ -640,7 +640,7 @@ public void decode(final ActiveMQBuffer buffer) {
deserializationWhiteList =
BufferHelper.readNullableSimpleStringAsString(buffer);
- enable1xPrefixes = buffer.readableBytes() > 0 ? buffer.readBoolean()
: null;
+ enable1xPrefixes = buffer.readableBytes() > 0 ? buffer.readBoolean()
: ActiveMQClient.DEFAULT_ENABLE_1X_PREFIXES;
--- End diff --
Btw, there was an ErrorProne warning for this,
```
[17:16:53][Step 3/3]
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/impl/ConnectionFactoryConfigurationImpl.java:643:
error: [NullTernary] This conditional expression may evaluate to null, which
will result in an NPE when the result is unboxed.
[17:16:53][Step 3/3] enable1xPrefixes = buffer.readableBytes() > 0 ?
buffer.readBoolean() : null;
[17:16:53][Step 3/3] ^
[17:16:53][Step 3/3] (see http://errorprone.info/bugpattern/NullTernary)
```
> Support 1x prefixes for JMS destinations instantiated using session
> -------------------------------------------------------------------
>
> Key: ARTEMIS-2023
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2023
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Fix For: 2.7.0, 2.6.3
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
