[ 
https://issues.apache.org/jira/browse/ARTEMIS-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589860#comment-16589860
 ] 

ASF GitHub Bot commented on ARTEMIS-1663:
-----------------------------------------

GitHub user michaelandrepearce opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2262

    ARTEMIS-1663 fix disparity on messagecount

    Reverting a change done in 1663.
    
    It seems the new messagecount != the original messageReferences.size all 
the time, it is more reliable to use the original messageReferences size as 
this is the actual collection's size.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaelandrepearce/activemq-artemis 
AREMIS1663-FIX

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2262.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2262
    
----
commit 2f9e30cde211950bf00cd9a00c05e09ae4dc6fea
Author: Michael André Pearce <michael.andre.pearce@...>
Date:   2018-08-23T07:50:34Z

    ARTEMIS-1663 fix disparity on messagecount
    
    Reverting a change done in 1663.
    
    It seems the new messagecount != the original messageReferences.size all 
the time, it is more reliable to use the original messageReferences size as 
this is the actual collection's size.

----


> Add enhanced message count and size metrics for Queues
> ------------------------------------------------------
>
>                 Key: ARTEMIS-1663
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1663
>             Project: ActiveMQ Artemis
>          Issue Type: New Feature
>          Components: Broker
>    Affects Versions: 2.4.0
>            Reporter: Christopher L. Shannon
>            Assignee: Christopher L. Shannon
>            Priority: Major
>             Fix For: 2.5.0
>
>
> The purpose of this Jira is to enhance the message count metrics and to add 
> size metrics for Queues.   By size metrics I mean the encoded size of all the 
> messages (for large messages this will include body as well).  Right now we 
> track memory usage but it is also very useful to know exactly how much data 
> is pending on a Queue to be consumed.  
> The scope of this will be support for tracking the count/size of pending 
> messages, count/size of delivering messages, and count/size of scheduled 
> messages.  For each of these categories durable size metrics will be tracked 
> as well. The paging store will also support tracking of size metrics as well.
> These new metrics will be exposed through JMX to allow users to view the 
> statistics.  Also by tracking these new values it will allow for enhanced 
> features in the future (ie new flow control options)
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to