Adrian Cole created ARTEMIS-2054:
------------------------------------
Summary: Artemis appears to never issue a JMS callback on error
Key: ARTEMIS-2054
URL: https://issues.apache.org/jira/browse/ARTEMIS-2054
Project: ActiveMQ Artemis
Issue Type: Improvement
Components: Broker
Affects Versions: 2.6.2
Environment: I'm trying to use artemis for Brave (zipkin java tracer)
testing of JMS 2.0 implementation.
I've noticed that the completion listener is never called on error. This might
be a concern beyond my testing. Here's how I found this..
I traced the use of CompletionListener in
org.apache.activemq.artemis.jms.client.ActiveMQMessageProducer. At what's
currently line 515, it is used, but wrapped with a type that will never call
the callback.
{{ if (completionListener != null) {}}
{{ clientProducer.send(address, coreMessage, new
CompletionListenerWrapper(completionListener, jmsMessage, this));}}
{{ } else {}}
{{ clientProducer.send(address, coreMessage);}}
{{ }}}
{{Also, all catch blocks won't call the callback either. It is possible I
missed something.}}
Reporter: Adrian Cole
I'm trying to use artemis for Brave (zipkin java tracer) testing of JMS 2.0
implementation.
I've noticed that the completion listener is never called on error. This might
be a concern beyond my testing. Here's how I found this..
I traced the use of CompletionListener in
org.apache.activemq.artemis.jms.client.ActiveMQMessageProducer. At what's
currently line 515, it is used, but wrapped with a type that will never call
the callback.
{{code}}
if (completionListener != null) {
clientProducer.send(address, coreMessage, new
CompletionListenerWrapper(completionListener, jmsMessage, this));
} else {
clientProducer.send(address, coreMessage);
}
{{code}}
Also, all catch blocks won't call the callback either.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
