[
https://issues.apache.org/jira/browse/ARTEMIS-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596508#comment-16596508
]
ASF GitHub Bot commented on ARTEMIS-2052:
-----------------------------------------
Github user cshannon commented on the issue:
https://github.com/apache/activemq-artemis/pull/2278
The issue is here:
https://github.com/apache/activemq-artemis/blob/106e71bdf4f1cf7ddf0dfc37ce6bab76d5c00dad/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/ConsumerWindowSizeTest.java#L1457
That line should now change to: assertTrue(Wait.waitFor(() ->
cons.getAvailableCredits().get() == consumer.getClientWindowSize() * 2, 5000,
500));
And that will fix it
> DefaultConsumerWindowSize is not properly being applied
> -------------------------------------------------------
>
> Key: ARTEMIS-2052
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2052
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.6.2
> Reporter: Christopher L. Shannon
> Assignee: Christopher L. Shannon
> Priority: Major
> Fix For: 2.7.0, 2.6.3
>
>
> When testing out the new defaultConsumerWindowSize setting I found 2 bugs.
> 1) The default value wasn't being applied properly in the client when using
> JMS topics. After debugging it turns it the reason is the queue name is
> being used to look up the address settings inside of the queueQuery() method
> in ActiveMQServerImpl however really we need to use the address name of the
> binding because the queue name for a topic will just be a random temporary
> string. I think the solution here is to check for a local queue binding
> first and if one exists then use the address name of the queue binding for
> looking up address settings.
> 2) After fixing part 1 the client had the proper value but the
> availableCredits being sent to the server for flow control was wrong and
> didn't use the negotiated value.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
