[ 
https://issues.apache.org/jira/browse/ARTEMIS-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607804#comment-16607804
 ] 

ASF GitHub Bot commented on ARTEMIS-2081:
-----------------------------------------

GitHub user michaelandrepearce opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2300

    ARTEMIS-2081 listConfiguredQueues returns only queues created by config

    Extend test case to reproduce problem of client created queues being 
incorrectly removed on simple reload of config.
    Add a flag/field to the queues created by configuration/broker.xml so we 
can correctly filter only queues created/managed by config.
    Update listConfiguredQueues to use the new queue flag

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaelandrepearce/activemq-artemis 
ARTEMIS-2081

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2300.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2300
    
----
commit 3d6171c108b3015277e4c81fb9912e88254dd156
Author: Michael André Pearce <michael.andre.pearce@...>
Date:   2018-09-07T23:23:55Z

    ARTEMIS-2081 listConfiguredQueues returns only queues created by config
    
    Extend test case to reproduce problem of client created queues being 
incorrectly removed on simple reload of config.
    Add a flag/field to the queues created by configuration/broker.xml so we 
can correctly filter only queues created/managed by config.
    Update listConfiguredQueues to use the new queue flag

----


> When config reload occurs with deletion policy enabled, queues not created by 
> broker xml are removed
> ----------------------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-2081
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2081
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Michael Andre Pearce
>            Priority: Major
>
> This is related to feature https://issues.apache.org/jira/browse/ARTEMIS-1235
> listConfiguredQueues was meant to return queues which are managed by broker 
> xml, the intent is where a queue was created by a client (e.g. you configure 
> durable queues, but allow clients to make non-durable queues still) on reload 
> where the address exists, but the queue is not present, it would only remove 
> queues that are being managed by broker.xml
> unfortunately this is not returning only queues that are created/managed by 
> broker.xml, meaning on broker reload and the address is present, queues 
> created by clients get un-expectedly removed.
> We need to track/mark queues explicitly that are created by configuration 
> (broker.xml) and update the filter to use this new flag, to ensure only those 
> are touched.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to