[
https://issues.apache.org/jira/browse/ARTEMIS-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612405#comment-16612405
]
ASF GitHub Bot commented on ARTEMIS-2070:
-----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2307#discussion_r217096333
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientMessageImpl.java
---
@@ -400,17 +398,10 @@ public long getLargeBodySize() {
}
@Override
- public int encode(final ByteBuffer bufferRead) throws
ActiveMQException {
- ActiveMQBuffer buffer1 =
ActiveMQBuffers.wrappedBuffer(bufferRead);
- return encode(buffer1, bufferRead.capacity());
- }
-
- @Override
- public int encode(final ActiveMQBuffer bufferOut, final int size) {
--- End diff --
I'm trying to understand why this was removed? I'm not saying it's wrong..
just trying to understand it. Can you explain?
> broker can reduce buffer copies with large messages
> ---------------------------------------------------
>
> Key: ARTEMIS-2070
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2070
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Major
>
> While dealing with large messages, regardless of the protocol used, the
> broker is performing several buffer copies that could be saved to make the
> process less memory hungry, in particular when AMQP or OpenWire are used.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
