[
https://issues.apache.org/jira/browse/ARTEMIS-2067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612421#comment-16612421
]
ASF subversion and git services commented on ARTEMIS-2067:
----------------------------------------------------------
Commit d1939620c03dab8f4a3ac5b7da159b8c27f078d6 in activemq-artemis's branch
refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=d193962 ]
ARTEMIS-2067 Clean up some code in the AMQP protocol handling paths
Cleans up some of the code on the proton event handler, most noteable:
1. Fix IOCallback creation on each outbound send, use single instance
as the handler only ever does a flush and has no attached state.
2. Fix redundent locking and unlocking of connection lock on the event
path that already ensures that lock is held.
3. Set presettle state on the server sender at attach as it cannot
change afterwards so checking on every message is not needed.
4. Improve buffer type checking on receive to reduce amount of work
> AMQP: Cleanup some proton event handling code
> ---------------------------------------------
>
> Key: ARTEMIS-2067
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2067
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.6.2
> Reporter: Timothy Bish
> Assignee: Timothy Bish
> Priority: Minor
> Fix For: 2.7.0
>
>
> There are a few small cleanups that can be made in the proton-j event handler
> code paths such as removing redundant locking and unlocking of the connection
> lock and reduce some garbage created on message sends.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
