[
https://issues.apache.org/jira/browse/ARTEMIS-2083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612444#comment-16612444
]
ASF GitHub Bot commented on ARTEMIS-2083:
-----------------------------------------
GitHub user tabish121 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2308
ARTEMIS-2083 Decode only the relavent portions of the message
Ensure that the Body of the message is never decoded in the partial
decode phase of the message processing and also gaurd against the
decode of ApplicationProperties which should be done lazily. Add
lazy decode of DeliveryAnnotations as they are not used at present.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-2083
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2308.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2308
----
commit cfe63355ddd3153d6107be8c1f2a8d3fdf411d02
Author: Timothy Bish <tabish121@...>
Date: 2018-09-12T16:42:45Z
ARTEMIS-2083 Decode only the relavent portions of the message
Ensure that the Body of the message is never decoded in the partial
decode phase of the message processing and also gaurd against the
decode of ApplicationProperties which should be done lazily. Add
lazy decode of DeliveryAnnotations as they are not used at present.
----
> AMQP: Ensure message elements are not decoded unless needed
> -----------------------------------------------------------
>
> Key: ARTEMIS-2083
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2083
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.6.3
> Reporter: Timothy Bish
> Assignee: Timothy Bish
> Priority: Major
> Fix For: 2.7.0
>
>
> With the right Message encoding the broker can mistakenly fully decode the
> AMQP message body when it should ever be doing so unless converting to Core.
> This can happen when no ApplicationProperties are present and a lazy decode
> attempt happen or it can occur if the Message doesn't carry and Properties or
> ApplicationProperties when the initial message partial decode happens.
> Likewise the broker can in some cases decode the Application Properties when
> they should only be decoded lazily.
> We can also skip decode of any delivery annotations as they are never used by
> the broker at the moment and we can lazy decode them later as needed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
