[
https://issues.apache.org/jira/browse/ARTEMIS-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623603#comment-16623603
]
ASF GitHub Bot commented on ARTEMIS-2093:
-----------------------------------------
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2325
ARTEMIS-2093 NPE thrown by NettyConnector::createConnection
Given that NettyConnector::createConnection isn't happening on the
channel's event loop, it could race with a channel close event, that
would clean the whole channel pipeline, leading to a NPE while
trying to use a configured channel handler of the pipeline.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/franz1981/activemq-artemis ARTEMIS-2093
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2325.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2325
----
commit 3112b4f3db6a77b3d996d72bac65d539d1135ce8
Author: Francesco Nigro <nigro.fra@...>
Date: 2018-09-21T13:06:53Z
ARTEMIS-2093 NPE thrown by NettyConnector::createConnection
Given that NettyConnector::createConnection isn't happening on the
channel's event loop, it could race with a channel close event, that
would clean the whole channel pipeline, leading to a NPE while
trying to use a configured channel handler of the pipeline.
----
> NPE thrown by NettyConnector::createConnection
> ----------------------------------------------
>
> Key: ARTEMIS-2093
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2093
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.6.3
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Minor
> Fix For: 2.7.0, 2.6.4
>
>
> On NettyConnector::createConnection,
> ChannelPipeline::get(ActiveMQChannelHandler.class) can return null, causing
> NPE, if the channel is being closed and/or the channel pipeline is being
> cleaned up before it.
> It can happen because NettyConnector::createConnection is not being called
> inside the channel's event loop and is concurrent with a channel close event
> (that's completed into the event loop).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
