[
https://issues.apache.org/jira/browse/ARTEMIS-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638408#comment-16638408
]
ASF GitHub Bot commented on ARTEMIS-2110:
-----------------------------------------
GitHub user gtully opened a pull request:
https://github.com/apache/activemq-artemis/pull/2346
ARTEMIS-2110 allow a lease renew without update to the expiry timesta…
…mp. Fix intermittent failure of
org.apache.activemq.artemis.core.server.impl.jdbc.JdbcLeaseLockTest#shouldRenewAcquiredLock
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gtully/activemq-artemis ARTEMIS-2110
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2346.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2346
----
commit ddf0cac2d7531dc49484c283a7f4cbe44d8e278e
Author: gtully <gary.tully@...>
Date: 2018-10-04T15:47:16Z
ARTEMIS-2110 allow a lease renew without update to the expiry timestamp.
Fix intermittent failure of
org.apache.activemq.artemis.core.server.impl.jdbc.JdbcLeaseLockTest#shouldRenewAcquiredLock
----
> JDBC LeaseLocker repeated renew or renew after aquire can fail in error
> -----------------------------------------------------------------------
>
> Key: ARTEMIS-2110
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2110
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.6.3
> Reporter: Gary Tully
> Assignee: Gary Tully
> Priority: Minor
> Fix For: 2.7.0
>
>
> There is an intermittent failure in:
> org.apache.activemq.artemis.core.server.impl.jdbc.JdbcLeaseLockTest#shouldRenewAcquiredLock
> (seems to block pr ci, and reproduced for me 20% of the time)
> if the db currentTime has not moved on, using the same lease time results in
> a failure. A renew immediately after acquiring the lock is a sensible pattern
> to verify the aquire.
>
> The lock renew needs >= in place or > on the WHERE clause to allow an
> 'identity' lease to succeed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
