[
https://issues.apache.org/jira/browse/ARTEMIS-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645194#comment-16645194
]
ASF GitHub Bot commented on ARTEMIS-2096:
-----------------------------------------
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/2361
ARTEMIS-2096 Fixing DivertTopicToQueueTest
This is fixing the test
org.apache.activemq.artemis.tests.integration.amqp.DivertTopicToQueueTest
This test was broken because the copy wouldn't use the Buffer view gotten
by data.duplicate().
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/activemq-artemis ARTEMIS-2096
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2361.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2361
----
commit a454316f77b84570483092381016e8305cdeca0b
Author: Clebert Suconic <clebertsuconic@...>
Date: 2018-10-10T16:09:40Z
ARTEMIS-2096 Fixing DivertTopicToQueueTest
This is fixing the test
org.apache.activemq.artemis.tests.integration.amqp.DivertTopicToQueueTest
This test was broken because the copy wouldn't use the Buffer view gotten
by data.duplicate().
----
> AMQP: Refactoring AMQPMessage abstraction for better consistency and
> performance
> --------------------------------------------------------------------------------
>
> Key: ARTEMIS-2096
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2096
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
> Affects Versions: 2.6.3
> Reporter: Timothy Bish
> Assignee: Timothy Bish
> Priority: Major
> Fix For: 2.7.0
>
>
> The AMQPMessage abstraction used to wrap the AMQP message section has some
> inconsistencies in how it manages the underlying data and the decoded AMQP
> section obtained from the Proton-J codec as well as issues with state being
> maintained in the presence of changes to the message made through the public
> facing Message APIs
> A refactoring of the AMQPMessage class to better utilize the proton-j codec
> to manage the message data and how it is parsed and re-encoded on change
> needs to be done to ensure no corrupt messages are sent and that we are not
> decoding and encoding sections of the message we are not intending to read or
> change on the sever (We currently can decode message bodies or footer is a
> few cases where we intend not to).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
