[
https://issues.apache.org/jira/browse/ARTEMIS-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645514#comment-16645514
]
ASF GitHub Bot commented on ARTEMIS-2117:
-----------------------------------------
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/2362
ARTEMIS-2117 Add custom LVQ Key and Non Destructive Queue into Broker
Implement custom LVQ Key and Non-Destructive in broker - protocol agnostic
Make feature configurable via broker.xml, core apis and
activemqservercontrol
Add last-value-key test cases
Add non-destructive with lvq test cases
Add non-destructive with expiry-delay test cases
Update documents
Add new methods to support create, update with new attributes
Refactor to pass through queue-attributes in client side methods to reduce
further method changes for adding new attributes in future and avoid methods
with endless parameters. (note: in future this should prob be done server side
too)
Update existing test cases and fake impls for new methods/attributes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelandrepearce/activemq-artemis
qpid-lvq-feature
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2362.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2362
----
commit 2af8fc924cbf4c56746331bd98b7c1547162e905
Author: Michael André Pearce <michael.andre.pearce@...>
Date: 2018-10-10T00:07:02Z
ARTEMIS-2117 Add custom LVQ Key and Non Destructive Queue into Broker
Implement custom LVQ Key and Non-Destructive in broker - protocol agnostic
Make feature configurable via broker.xml, core apis and
activemqservercontrol
Add last-value-key test cases
Add non-destructive with lvq test cases
Add non-destructive with expiry-delay test cases
Update documents
Add new methods to support create, update with new attributes
Refactor to pass through queue-attributes in client side methods to reduce
further method changes for adding new attributes in future and avoid methods
with endless parameters. (note: in future this should prob be done server side
too)
Update existing test cases and fake impls for new methods/attributes
----
> Add QPID LVQ Features into Broker
> ---------------------------------
>
> Key: ARTEMIS-2117
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2117
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.6.3
> Reporter: Michael Andre Pearce
> Assignee: Michael Andre Pearce
> Priority: Major
>
> To assist users migrating from qpid to artemis.
> Currently LVQ in artemis uses a fixed message property for the LVQ key, Qpid
> supports queues to have custom/arbitrary message property to be the LVQ key,
> this is more flexible.
> [http://qpid.apache.org/releases/qpid-broker-j-7.0.1/book/Java-Broker-Concepts-Queues.html#Java-Broker-Concepts-Queues-Types-LVQ]
>
> Also an additional feature typically used with LVQ's in qpid is ability to
> mark a queue non-destructive.
> [http://qpid.apache.org/releases/qpid-broker-j-7.0.1/book/Java-Broker-Concepts-Queues.html#Java-Broker-Concepts-Queue-EnsureNonDestructiveConsumers]
>
> As such this is to add both support ability to use a arbitrary last-value-key
> for LVQ and for support of setting a queue to be non-destructive, at the
> broker level and via core apis.
> Scope is to add basic feature into the broker and core apis, out of scope is
> dynamic creation from a client via amqp which would be a later piece of work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
