[
https://issues.apache.org/jira/browse/ARTEMIS-1898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645630#comment-16645630
]
ASF GitHub Bot commented on ARTEMIS-1898:
-----------------------------------------
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/2364
ARTEMIS-1898 Proper fix on AtomicRunnables and avoiding leaks
GlobalDiskFullTest was broken before this fix.
Basically when using multiple addresses over a session you would miss flow
credits on all your producers except to the first one
that ran out of credit.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/activemq-artemis tosend
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2364.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2364
----
commit 39a5701964e506bc81e653ef05296356e3fcb610
Author: Clebert Suconic <clebertsuconic@...>
Date: 2018-10-10T22:09:28Z
ARTEMIS-1898 Proper fix on AtomicRunnables and avoiding leaks
GlobalDiskFullTest was broken before this fix.
Basically when using multiple addresses over a session you would miss flow
credits on all your producers except to the first one
that ran out of credit.
----
> [AMQP] sender is not granted credit once space on queue is available
> --------------------------------------------------------------------
>
> Key: ARTEMIS-1898
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1898
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Gordon Sim
> Assignee: Andy Taylor
> Priority: Major
> Fix For: 2.6.4
>
> Attachments: drain.py, test_send.py
>
>
> If an AMQP publisher sends to a queue that is full, with
> address-full-policy=FAIL, it gets messages rejected and no credit issued as
> expected. However if the queue is then drained, that existing sender link is
> not granted any more credit.
> To reproduce, configure a broker such that it has a queue called examples
> with some fairly low max size (I set global-max-size to 100kb) and
> address-full-policy of FAIL. Then run attached test_send.py with args e.g. -m
> 100000. The sender will eventually stall due to lack of credit. Then run the
> attached drain.py which will drain the queue. This *should* allow the sender
> to resume sending, but it does not.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
