[
https://issues.apache.org/jira/browse/ARTEMIS-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651243#comment-16651243
]
ASF GitHub Bot commented on ARTEMIS-2123:
-----------------------------------------
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2369#discussion_r225419711
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java
---
@@ -599,6 +600,18 @@ private long checkMinPage(Collection<PageSubscription>
cursorList) {
}
+ private void deliverIfNecessary(Collection<PageSubscription>
cursorList, long minPage) {
+ for (PageSubscription cursor : cursorList) {
+ long firstPage = cursor.getFirstPage();
+ if (firstPage == minPage) {
+ if (cursor.getQueue().getMessageCount() == 0 &&
cursorList.size() > 1) {
+ cursor.getQueue().deliverAsync();
+ break;
--- End diff --
The `break` could be taken out, landing into `if (firstPage == minPage) {
..break; }`?
@wy96f @clebertsuconic how many cursors can have `cursor.getFirstPage() ==
minPage`?
> Paging not stopped if there are no consumers on one subscription
> ----------------------------------------------------------------
>
> Key: ARTEMIS-2123
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2123
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.6.3
> Reporter: yangwei
> Priority: Major
>
> Reproduction steps:
> # create a topic t and two subscriptions ta, tb
> # send messages to ta and tb
> # create ta consumers and receive all messages from ta
> # close consumers
> # only send message to tb
> # create tb consumers and receive all message from tb
> # topic not stopped paging
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
