[ 
https://issues.apache.org/jira/browse/AMQ-6590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16654678#comment-16654678
 ] 

Jeff Genender commented on AMQ-6590:
------------------------------------

Hi Alan... that's awesome!  That would totally work in cutting down the 
potential for the recovery. May I suggest that you open a new Jira to track 
this since this one is resolved.  Right now parts of this are in multiple 
releases, so its own Jira may help ensure we know what release it would be a 
part of.   Your code looks pretty clear and I think it deserves its own JIRA  
Please reference this one in the new JIRA.

> KahaDB index loses track of free pages on unclean shutdown
> ----------------------------------------------------------
>
>                 Key: AMQ-6590
>                 URL: https://issues.apache.org/jira/browse/AMQ-6590
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.14.3
>            Reporter: Christopher L. Shannon
>            Assignee: Christopher L. Shannon
>            Priority: Major
>             Fix For: 5.15.0, 5.14.4, 5.16.0, 5.15.7
>
>
> I have discovered an issue with the KahaDB index recovery after an unclean 
> shutdown (OOM error, kill -9, etc) that leads to excessive disk space usage. 
> Normally on clean shutdown the index stores the known set of free pages to 
> db.free and reads that in on start up to know which pages can be re-used.  On 
> an unclean shutdown this is not written to disk so on start up the index is 
> supposed to scan the page file to figure out all of the free pages.
> Unfortunately it turns out that this scan of the page file is being done 
> before the total page count value has been set so when the iterator is 
> created it always thinks there are 0 pages to scan.
> The end result is that every time an unclean shutdown occurs all known free 
> pages are lost and no longer tracked.  This of course means new free pages 
> have to be allocated and all of the existing space is now lost which will 
> lead to excessive index file growth over time.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to