[
https://issues.apache.org/jira/browse/ARTEMIS-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661503#comment-16661503
]
ASF GitHub Bot commented on ARTEMIS-2141:
-----------------------------------------
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2384#discussion_r227607588
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConsumerView.java
---
@@ -89,6 +90,8 @@ public Object getField(ServerConsumer consumer, String
fieldName) {
return consumer.getQueueName();
case "queueType":
return consumer.getQueueType();
+ case "filter":
+ return consumer.getFilter() == null ? "" :
consumer.getFilter().getFilterString();
--- End diff --
Rather than the dupe logic here and on line 61, create a method to
getFilterString.
Also if null, should return null, not empty string.
return filter != null ? filter.getFilterString().toString() : null;
e.g. should be same logic as in QueueControlImpl
> Display "Filter" column in Consumers View of AdminUI
> ----------------------------------------------------
>
> Key: ARTEMIS-2141
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2141
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: 2.6.3
> Reporter: Sebastian T
> Priority: Trivial
>
> Currently the message filter of consumers is not displayed in the Consumers
> View, this however is valuable info while troubleshooting.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
