[ 
https://issues.apache.org/jira/browse/ARTEMIS-2130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661516#comment-16661516
 ] 

ASF GitHub Bot commented on ARTEMIS-2130:
-----------------------------------------

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2376#discussion_r227609451
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConnectionView.java
 ---
    @@ -51,10 +51,14 @@ public JsonObjectBuilder toJson(RemotingConnection 
connection) {
     
           List<ServerSession> sessions = 
server.getSessions(connection.getID().toString());
           Set<String> users = new HashSet<>();
    +      String clientID = null;
     
           for (ServerSession session : sessions) {
              String username = session.getUsername() == null ? "" : 
session.getUsername();
              users.add(username);
    +         if (clientID == null) {
    +            clientID = session.getMetaData("jms-client-id") == null ? 
connection.getClientID() : session.getMetaData("jms-client-id");
    --- End diff --
    
    should avoid jms specifics such as this.
    



> Web console display blank ClientID for the core client.
> -------------------------------------------------------
>
>                 Key: ARTEMIS-2130
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2130
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: 2.6.3
>            Reporter: Shailendra Kumar singh
>            Priority: Major
>         Attachments: ConnectionView.png, ProducersView.png
>
>
> Web console display blank ClientID for the core client. 
> connection.setClientID("Test2"); Web console display blank, attached 
> screen-shot.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to