Gary Tully created AMQ-7086:
-------------------------------

             Summary: KahaDB - don't perform expensive gc run on shutdown
                 Key: AMQ-7086
                 URL: https://issues.apache.org/jira/browse/AMQ-7086
             Project: ActiveMQ
          Issue Type: Bug
          Components: KahaDB
    Affects Versions: 5.15.0
            Reporter: Gary Tully
            Assignee: Gary Tully
             Fix For: 5.16.0


when looking at the speed of broker.stop with kahadb and the scheduler store. 
There is a full gc run, which can be expensive as the whole index needs to be 
traversed.

Fast stop/restart is important for fast failover. Leaving gc for to runtime, 
where it has an effect on latency rather than availability is better.

 

I am wondering if there is a use case for gc only at shutdown if the 
cleanupInterval <= 0, indicating that there were no gc at runtime. The 
alternative is adding another boolean to the config or adding that back in if 
the need arises.

I am leaning towards just removing the gc call during shutdown.

 

Note: matching the indexCacheSize to the index file size, trading off with 
memory, does help to speed up the index (read) traversal.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to