[
https://issues.apache.org/jira/browse/ARTEMIS-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668940#comment-16668940
]
ASF GitHub Bot commented on ARTEMIS-2155:
-----------------------------------------
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2403
ARTEMIS-2155 disconnect on failure to handle packet
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-2155
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2403.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2403
----
commit cb627379a05d47b45874c970a8113d6a68e047ae
Author: Justin Bertram <jbertram@...>
Date: 2018-10-23T18:06:22Z
ARTEMIS-2155 disconnect on failure to handle packet
----
> Failure to handle packet should force consumer to disconnect
> ------------------------------------------------------------
>
> Key: ARTEMIS-2155
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2155
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.6.3
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
>
> Usually when a core client fails to decode an incoming buffer it logs the
> failure and disconnects. However, there are a few situations where the
> failure is logged, but the client *doesn't* disconnect. This can lead to
> client starvation situations involving flow control where the broker thinks
> the client has successfully received the packet but the client doesn't update
> it's credits and therefore doesn't ask for additional credits. The client
> should disconnect consistently when it has problems decoding a packet.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
